Skip to content

DOC: Add missing parameters to offsets class: Tick #58948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Anh-HoDac
Copy link

@Anh-HoDac Anh-HoDac commented Jun 6, 2024

@Anh-HoDac Anh-HoDac requested a review from MarcoGorelli as a code owner June 6, 2024 16:53
Copy link
Member

@Aloqeely Aloqeely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Anh-HoDac
Copy link
Author

Thank you @Aloqeely! I have committed to the suggested change.

@mroeschke
Copy link
Member

Could you address these failing check?

Error: None:None:EX01:pandas.tseries.offsets.Tick:No examples section found
Error: None:None:GL08:pandas.tseries.offsets.Tick:EXPECTED TO FAIL, BUT NOT FAILING

@mroeschke mroeschke added the Docs label Jun 18, 2024
@MarcoGorelli
Copy link
Member

hi @Anh-HoDac - this looks to be on the right track, if you can add an example to the docstring I think it can go in

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants