TST: Testing bug in reading json/msgpack from a non-filepath on windows under py3 (GH5874) #5894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws under py3 (GH5874)
|
@y-p I can't test this directly on py3 on windows...but should work can you give a run? |
|
I have a PR almost ready for changing the signature on this and read_msgpack to accept I'm not keen on being the windows tester around here. It looks ok, merge and see if it's green? |
|
ok....will merge if its green see if it fixes....then go ahead an break the API if needed..sure |
jreback
added a commit
that referenced
this pull request
Jan 9, 2014
TST: Testing bug in reading json/msgpack from a non-filepath on windows under py3 (GH5874)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5874