BUG: Refactor construction process for MaskedArrays in series constructors #58900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Jun 3, 2024
Comment on lines
+522
to
+526
| if not mask.all(): | ||
| idx = np.unravel_index(np.nanargmax(data, axis=None), data.shape) | ||
| if not mask[idx] and int(data[idx]) != original[idx]: | ||
| if is_integer_dtype(original_dtype) and is_float_dtype(data.dtype): | ||
| data = ma.asarray(original, "object") |
There was a problem hiding this comment.
I'm not sure if this is the appropriate solution. Converting to object should be avoided
There was a problem hiding this comment.
Could you please expand on your idea? What could I use instead of an object? Thanks for your help!
There was a problem hiding this comment.
I imagine the dtype output from maybe_promote isn't entirely appropriate given the original issue. Casting to object would cover up the root issue. This issue I suspect is fairly non-trivial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.