REF/block the implicit cast of datetime.datetime to pa.date32() #58855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
May 30, 2024
| @@ -427,6 +428,8 @@ def _box_pa_scalar(cls, value, pa_type: pa.DataType | None = None) -> pa.Scalar: | |||
| pa_scalar = value | |||
| elif isna(value): | |||
| pa_scalar = pa.scalar(None, type=pa_type) | |||
| elif pa_type == pa.date32() and isinstance(value, datetime.datetime): | |||
There was a problem hiding this comment.
@PedroVerardo this is a nice find, but if pyarrow supports it I don't think we should do anything special in pandas to handle this. Looks like we should just open the issue upstream
|
Really appreciate the research into this @PedroVerardo . From what you discovered the issue is upstream in pyarrow - I copied you on the issue there so let's close this and track upstream. Sorry there is nothing to merge into pandas but once again thanks for your efforts on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The change I made probably doesn't change the entire problem because the code continues to cast all other pyarrow types.