REF/API: make construct_array_type a non-classmethod

[miguelpgarcia]

• closes REF/API: make construct_array_type a non-classmethod #58663
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.

[miguelpgarcia]

Since it is already a non-classmethod in StringArray, making the abstract method non-classmethod would ensure code consistency.

[miguelpgarcia]

Since it's my first PR, I would greatly appreciate your valuable feedback @jbrockmendel

[jbrockmendel]

#58663 is not a good issue for a beginner. please look for an issue with the "good first issue" label

[miguelpgarcia]

I did indeed look for some alternatives with this label, but ultimately concluded that this issue remained the most appropriate one and the one I was most interested in investigating further.

[jbrockmendel]

concluded that this issue remained the most appropriate one

It is not. Please look again.

[miguelpgarcia]

I apologize if I chose an inappropriate issue. I consulted with a colleague who has previously contributed to this repository and they assured me it was fine. If anything is missing from the modified files, or if further discussion/research regarding the issue is needed, that's perfectly okay.

[jbrockmendel]

The hard part of addressing #58663 is not changing a few lines of code, but in achieving consensus that it is a change we want to make, then in making the change without breaking 3rd party subclasses.

[mroeschke]

Thanks for the PR @miguelpgarcia but agreed that making a PR is premature at this point and would need more coordination to start opening a PR to address. Going to close, but happy to have your contributions towards issues labeled good first issue