-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: Read excel parse refactor #58497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rhshadrach
merged 28 commits into
pandas-dev:main
from
iangainey:read-excel-parse-refactor
May 1, 2024
Merged
Changes from 19 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c14b536
Initial commit for PR
iangainey 396d0a6
Added whats new enhancement
iangainey d8f8bdf
Merge branch 'main' into main
iangainey ff5b722
Resolving commit checks
iangainey 6c948cb
Merge branch 'main' of https://github.com/iangainey/pandas
iangainey 182627e
Removing local testing comments
iangainey 6c17196
Attempting to resolve ruff-format failure that is not occuring on my …
iangainey d036bb5
Resolving typing and docstring manual pre-commit errors
iangainey ea15154
Removing type hints considering typing checks doesn't like it
iangainey 748d90f
These errors make no sense and contradict what I am seeing
iangainey 1e2b0f5
Refactor of parse for precursor
iangainey 266b66d
Cleaning up
iangainey 7615ddc
Fixing type errors
iangainey 0961828
Trying to fix type errors again
iangainey 1eeecc1
Trying to fix type errors again
iangainey 67a5733
Trying to fix type errors again
iangainey 7c9b927
Trying to fix type errors again
iangainey 5ec999e
Finally cleaning up
iangainey 24993be
Cleaning up for final commit
iangainey 351d875
Merge branch 'main' into read-excel-parse-refactor
iangainey a86abb4
Modified naming to mark as internal to class
iangainey 0b8ed90
Merge branch 'read-excel-parse-refactor' of https://github.com/iangai…
iangainey 0e53a4d
Restrcutred based on refactor and solved some typing errors
iangainey a55f77b
Fixing what's new changes
iangainey 1713918
Cleaning up changes to tests
iangainey 121ecd2
Merge branch 'main' into main
iangainey fa0782f
Branched table parameter feature and merged in parse refactor
iangainey 9ec25f2
Accidently changed what's new
iangainey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this class is in the public API, we'll want to mark this internal. Can you rename to
_parse_sheet
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, I've corrected it. Thank you for taking a loot at it. Let me know if there's anything else that can be changed or improved in this PR!