Skip to content

BUG: hashing read only object categories raises #58481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2024
Merged

BUG: hashing read only object categories raises #58481

merged 2 commits into from
Apr 30, 2024

Conversation

phofl
Copy link
Member

@phofl phofl commented Apr 29, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

CoW related, so no whatsnew needed

@phofl phofl requested a review from WillAyd as a code owner April 29, 2024 22:50
@phofl phofl added this to the 3.0 milestone Apr 29, 2024
@phofl phofl added the hashing hash_pandas_object label Apr 29, 2024
WillAyd
WillAyd approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phofl phofl merged commit 59f6a33 into pandas-dev:main Apr 30, 2024
46 checks passed
@phofl phofl deleted the hash_read_only_object_array branch April 30, 2024 20:02
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@phofl @pmhatre1
BUG: hashing read only object categories raises (pandas-dev#58481)
bb399a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
hashing hash_pandas_object
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @WillAyd