TST: Added match argument for most uses of tm.assert_produces_warning #58396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
mroeschke
approved these changes
Apr 24, 2024
|
Thanks @Aloqeely (agreed that it would be nice to enforce |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…pandas-dev#58396) * Fix for all FutureWarnings * Add match for most warnings * Cleaner code --------- Co-authored-by: Abdulaziz Aloqeely <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #58290
Places where I skipped match argument:
computation/test_eval.pyandframe/test_query_eval.pyas I couldn't get the tests to trigger the warningplotting/test_datetimelike.pysame reason as above.The tests for internal things in
utilfolder:test_assert_produces_warning.py,test_deprecate_kwarg.py,test_deprecate_nonkeyword_arguments.py,test_deprecate.pyother places I skipped because it would complicate the logic (I.E.
api/test_api.py'stest_deprmethod.)