BUG: Add frequency to DatetimeArray/TimedeltaArray take #58382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annika-rudolph
changed the title
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
2 times, most recently
from
19d396d to
5440815
Compare
annika-rudolph
changed the title
annika-rudolph
changed the title
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
from
30a69e1 to
30be34a
Compare
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
from
195a9a5 to
e67ca27
Compare
pandas/core/indexes/multi.py
Outdated
| @@ -1244,7 +1244,9 @@ def _constructor(self) -> Callable[..., MultiIndex]: # type: ignore[override] | |||
| return type(self).from_tuples | |||
|
|
|||
| @doc(Index._shallow_copy) | |||
| def _shallow_copy(self, values: np.ndarray, name=lib.no_default) -> MultiIndex: | |||
| def _shallow_copy( | |||
There was a problem hiding this comment.
if the options are doing this in take or shallow_copy, take is definitely preferred
There was a problem hiding this comment.
done -- implemented via take
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
from
d49d42c to
b2a244a
Compare
annika-rudolph
changed the title
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
2 times, most recently
from
cae8e63 to
ceb3633
Compare
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
2 times, most recently
from
4bedc39 to
9b480bf
Compare
jbrockmendel
reviewed
May 8, 2024
pandas/core/arrays/datetimelike.py
Outdated
|
|
||
| if isinstance(maybe_slice, slice): | ||
| freq = self._get_getitem_freq(maybe_slice) | ||
| result.freq = freq |
There was a problem hiding this comment.
i think if you set result._freq it will be more performant
There was a problem hiding this comment.
Hi @jbrockmendel is this now corresponding to your idea?
There was a problem hiding this comment.
Hi @jbrockmendel , any news on this? would be nice to finish the PR at some point :)
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
from
9b480bf to
b5e228b
Compare
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
6 times, most recently
from
342ee5e to
6a2649b
Compare
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
4 times, most recently
from
a8788a0 to
ab23100
Compare
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
3 times, most recently
from
dad1473 to
d6f0e86
Compare
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
3 times, most recently
from
fae221c to
05e2bb6
Compare
…ray docstring make pre-commit happy
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
from
05e2bb6 to
0dd9feb
Compare
mroeschke
approved these changes
Jul 11, 2024
|
Thanks @annika-rudolph (sorry for the delay here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Disclaimer
I am required to add that the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. In no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.