Skip to content

REF: Defer creating Index._engine until needed #58370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

REF: Defer creating Index._engine until needed #58370

merged 1 commit into from
Apr 23, 2024

Conversation

mroeschke
Copy link
Member

Avoids creating Index._engine if it's not practically used and has not been created yet

@mroeschke mroeschke added Refactor Internal refactoring of code Index Related to the Index class or subclasses labels Apr 22, 2024
@mroeschke mroeschke added this to the 3.0 milestone Apr 22, 2024
@jbrockmendel
Copy link
Member

Lgtm

@mroeschke mroeschke merged commit bfe5be0 into pandas-dev:main Apr 23, 2024
49 of 50 checks passed
@mroeschke mroeschke deleted the ref/idx/_engine branch April 23, 2024 01:32
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@mroeschke @pmhatre1
REF: Defer creating Index._engine until needed (pandas-dev#58370)
097d032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Refactor Internal refactoring of code
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jbrockmendel