Skip to content

TST: Add tests for #55431 #58367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2024
Merged

TST: Add tests for #55431 #58367

merged 6 commits into from
Apr 29, 2024

Conversation

jasonmokk
Copy link
Contributor

@jasonmokk jasonmokk commented Apr 22, 2024

Created unit test in tests/reshape/test_cut.py to ensure pd.cut handles DatetimeArray without raising an AttributeError.

@jasonmokk jasonmokk marked this pull request as draft April 22, 2024 01:35
@jasonmokk jasonmokk marked this pull request as ready for review April 22, 2024 03:12
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Apr 22, 2024
@jasonmokk jasonmokk changed the title Add tests for #55431 TST: Add tests for #55431 Apr 26, 2024
@mroeschke mroeschke added this to the 3.0 milestone Apr 29, 2024
@mroeschke mroeschke merged commit d038da8 into pandas-dev:main Apr 29, 2024
46 checks passed
@mroeschke
Copy link
Member

Thanks @jasonmokk

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* Add tests for pandas-dev#55431

* Fix inconsistent pandas namespace usage

* Fix inconsistent pandas namespace usage again

* Temp disable part of test potentialy due to known bug

* Remove unnecessary comments and adjust implementation

---------

Co-authored-by: Jason Mok <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: AttributeError: 'DatetimeArray' object has no attribute 'notna' in pandas 2.1.1
2 participants