ENH: Implement cummax and cummin in _accumulate() for ordered Categorical arrays #58360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…das-brandon into accumulate_categorical
…das-brandon into accumulate_categorical
mroeschke
reviewed
Apr 22, 2024
mroeschke
reviewed
Apr 22, 2024
| import numpy as np | ||
|
|
||
|
|
||
| def _cum_func( |
There was a problem hiding this comment.
Can you just include all this logic in pandas/core/arrays/categorical.py
There was a problem hiding this comment.
I moved the logic into pandas/core/arrays/categorical.py
mroeschke
reviewed
Apr 22, 2024
mroeschke
added
Categorical
Co-authored-by: Matthew Roeschke <[email protected]>
…das-brandon into accumulate_categorical
mroeschke
reviewed
Apr 23, 2024
| ["a", np.nan, "b", "a", "c"], | ||
| dtype=pd.CategoricalDtype(list(order), ordered=True), | ||
| ) | ||
| result = getattr(ser, method)(skipna=True) |
There was a problem hiding this comment.
Could you use pytest.mark.parametrize with skipna=True|False and the expected result?
There was a problem hiding this comment.
Added a pytest.mark.parametrize to test_cummax_cummin_ordered_categorical_nan with skipna and expected data
mroeschke
reviewed
Apr 23, 2024
Comment on lines
205
to
207
| pd.Series( | ||
| ["a", np.nan, "b", "b", "c"], | ||
| dtype=pd.CategoricalDtype(list(order), ordered=True), |
There was a problem hiding this comment.
Can you assign this to an expected variable?
There was a problem hiding this comment.
Assigned all expected series to expected variables
…ametrize to test_cummax_cummin_ordered_categorical_nan with skipna and expected data
mroeschke
approved these changes
Apr 23, 2024
|
Thanks @bdwzhangumich |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…ical arrays (pandas-dev#58360) * Added tests with and without np.nan * Added tests for cummin and cummax * Fixed series tests expected series, rewrote categorical arrays to use pd.Categorical * Fixed cat not defined error and misspelling * Implement _accumulate for Categorical * fixed misspellings in tests * fixed expected categories on tests * Updated whatsnew * Update doc/source/whatsnew/v3.0.0.rst Co-authored-by: Matthew Roeschke <[email protected]> * Removed testing for _accumulate. * Moved categorical_accumulations.py logic to categorical.py * Assigned expected results to expected variable; Added pytest.mark.parametrize to test_cummax_cummin_ordered_categorical_nan with skipna and expected data --------- Co-authored-by: Christopher Xiang <[email protected]> Co-authored-by: Matthew Roeschke <[email protected]> Co-authored-by: Chris Xiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.We implemented the operations cummax and cummin in the _accumulate() function for the Categorical array class. The implementation includes a check that the Categorical array is ordered and is based on other implementations of _accumulate(). Tests for the implementation have also been written and included.
Coauthored with @xiangchris