BUG: Fixed merge between int64 uint64 and wrote test #58332
Closed
+25
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int64
anduint64
when using values >= 2**53 #56367When you have two DataFrames, left and right, where left's key is of dtype int64 while right's key is of dtype uint64, and both of their values are >= 2**53, what used to happen was that calling left.merge(right) will cause a non empty result to be returned. However, we want the merge function to return nothing since we shouldn't be allowing the merge between DataFrames with different key dtypes.
The issue was that when you are working with values >= 253 and you have keys that are of dtype int64 and uint64, the "common dtype" gets resolved to float64 for both, so a (253) int64 and (2**53 + 1) uint64 is represented as the same float64 value.