CLN: Use more memoryviews #58330
Merged
CLN: Use more memoryviews #58330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,7 +80,7 @@ def unstack(numeric_object_t[:, :] values, const uint8_t[:] mask, | |||
|
|
|||
| @cython.wraparound(False) | |||
| @cython.boundscheck(False) | |||
| def explode(ndarray[object] values): | |||
There was a problem hiding this comment.
can we get here with a readonly ndarray?
There was a problem hiding this comment.
Looks like in our testing this array is always writable (from mgr.internal_values()), should this be readonly?
There was a problem hiding this comment.
I think it can depend on what user passed to the constructor
There was a problem hiding this comment.
Gotcha. Well specifically here, we can't use const as that's not supported with object memoryviews
kvnwng11
pushed a commit
to kvnwng11/pandas
that referenced
this pull request
Apr 22, 2024
* Add memoryviews in reshape.pyx * Use more const memoryviews
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Add memoryviews in reshape.pyx * Use more const memoryviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.