Skip to content

Avoid unnecessary re-opening of HDF5 files (Closes: #58248) #58275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

avalentino
Copy link
Contributor

@@ -405,7 +405,7 @@ I/O
- Bug in :meth:`DataFrame.to_excel` when writing empty :class:`DataFrame` with :class:`MultiIndex` on both axes (:issue:`57696`)
- Bug in :meth:`DataFrame.to_string` that raised ``StopIteration`` with nested DataFrames. (:issue:`16098`)
- Bug in :meth:`read_csv` raising ``TypeError`` when ``index_col`` is specified and ``na_values`` is a dict containing the key ``None``. (:issue:`57547`)

- Enhancement in :meth:`to_hdf` avoid unnecessary reopenings of the HDF5 file to speedup data addition to files with a very large number of groups . (:issue:`58248`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this under the Performance improvements section?

@mroeschke mroeschke added Performance Memory or execution speed performance IO HDF5 read_hdf, HDFStore labels Apr 16, 2024
@mroeschke mroeschke added this to the 3.0 milestone Apr 16, 2024
@mroeschke mroeschke merged commit bb0fcc2 into pandas-dev:main Apr 16, 2024
46 checks passed
@mroeschke
Copy link
Member

Thanks @avalentino

@avalentino avalentino deleted the feature/no-hdf-reopen branch April 16, 2024 19:06
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…pandas-dev#58275)

* Avoid unnecessary re-opening of HDF5 files

* Update the whatsnew file

* Move the changelog entry for pandas-dev#58248 to the correct section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HDF5 read_hdf, HDFStore Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERF: Saving many datasets in a single group slows down with each new addition
2 participants