REF: Use more cython memoryviews #58271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Refactor
WillAyd
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Looks good. No performance regressions right? I can't remember what the difference is between arrays / memoryviews but I vaguely recall a common attribute access that Cython would make a C-level access into a Python access when switching from arrays to memviews
mroeschke
force-pushed
the
ref/cython3changes
branch
from
19ceb2e to
c5131ab
Compare
Running the ASVs locally show no performance impacts. |
WillAyd
approved these changes
Apr 17, 2024
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* fix some cython 3 todos * Another memoryview * Add another memoryview * Use more memoryview * another memoryview * more memoryview syntax in groupby * Add a few more memoryviews * Use Py_ssize_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also addresses some
# TODO(cython3) comments