REF: Clean up some iterator usages #58267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
approved these changes
Apr 15, 2024
@WillAyd Could you re-post your comment? I don't see it in this PR yet |
WillAyd
reviewed
Apr 16, 2024
pandas/core/frame.py
Outdated
| @@ -3705,7 +3705,7 @@ def transpose( | |||
| nv.validate_transpose(args, {}) | |||
| # construct the args | |||
|
|
|||
| dtypes = list(self.dtypes) | |||
| first_dtype = next(iter(self.dtypes), None) | |||
There was a problem hiding this comment.
Can't this just be self.dtypes[0] if self.dtypes else None? Going through the iteration protocol seems overkill
There was a problem hiding this comment.
Yup sure thing. Will change to this
WillAyd
approved these changes
Apr 16, 2024
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Use better data structures * Use generator and set * Move sorted to exception block, use set instead of list * Another iterator, use iter * another set * Dont use iterator protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.