Iterates through each path from self._clean_trees to improve error ha… #58263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndling with shutil.rmtree()
Aloqeely
reviewed
Apr 15, 2024
setup.py
Outdated
| # Remove the directory tree at the specified path | ||
| shutil.rmtree(path) | ||
| except OSError: | ||
| pass |
There was a problem hiding this comment.
Instead of iterating through clean_tree, I would recommend reverting the changes done in #54236 (setup.py) which caused self._clean_trees to be a list of generators.
EDIT: Using generator comprehension is intended, so you should probably fix the current logic of self._clean_trees such that it is a list of paths (strings) and not generators.
self._clean_trees.extend(...) instead of self_clean_trees.append(...) should be sufficient.
There was a problem hiding this comment.
Extend self._clean_trees by converting generator to list using list comprehension
This finds all "pycache" directories in the current root and appends their full paths to self._clean_trees
self._clean_trees.extend([os.path.join(root, dir) for dir in dirs if dir == "__pycache__"])
#and
self._clean_trees.extend([os.path.join(os.getcwd(), dir) for dir in ("build", "dist") if os.path.exists(dir)])…error handling with shutil.rmtree()" This reverts commit 5535d85.
|
Thanks for this PR but going to close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pyscript, aTypeErroroccurs in theshutil.rmtree()function due to a generator being passed instead of a valid path. #58262 (Replace xxxx with the GitHub issue number)