ENH: DtypeWarning message enhancement #58250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeltavares
force-pushed
the
ENH/DtypeWarning-message-enhancement
branch
5 times, most recently
from
89369f5 to
8c6b027
Compare
mroeschke
reviewed
Apr 15, 2024
doc/source/whatsnew/v3.0.0.rst
Outdated
| @@ -37,6 +37,7 @@ Other enhancements | |||
| - Users can globally disable any ``PerformanceWarning`` by setting the option ``mode.performance_warnings`` to ``False`` (:issue:`56920`) | |||
| - :meth:`Styler.format_index_names` can now be used to format the index and column names (:issue:`48936` and :issue:`47489`) | |||
| - :meth:`DataFrame.cummin`, :meth:`DataFrame.cummax`, :meth:`DataFrame.cumprod` and :meth:`DataFrame.cumsum` methods now have a ``numeric_only`` parameter (:issue:`53072`) | |||
| - ``DtypeWarning`` improved to include column names when mixed data types are detected (:issue:`58174`) | |||
There was a problem hiding this comment.
Suggested change
| - ``DtypeWarning`` improved to include column names when mixed data types are detected (:issue:`58174`) | |
| - :class:`.errors.DtypeWarning` improved to include column names when mixed data types are detected (:issue:`58174`) |
mroeschke
reviewed
Apr 15, 2024
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| from pandas.io.parsers.c_parser_wrapper import _concatenate_chunks | |||
|
|
|||
| COLUMN_NAMES = ["column_0", "column_1"] | |||
There was a problem hiding this comment.
Could you just inline this where it's used?
mroeschke
reviewed
Apr 15, 2024
|
|
||
| if warning_columns: | ||
| warning_names = ",".join(warning_columns) | ||
| warning_names = ", ".join( | ||
| [f"{index}: {name}" for index, name in enumerate(warning_columns, start=0)] |
There was a problem hiding this comment.
Suggested change
| [f"{index}: {name}" for index, name in enumerate(warning_columns, start=0)] | |
| [f"{index}: {name}" for index, name in enumerate(warning_columns)] |
mroeschke
added
IO CSV
abeltavares
force-pushed
the
ENH/DtypeWarning-message-enhancement
branch
from
8c6b027 to
d050d4e
Compare
abeltavares
force-pushed
the
ENH/DtypeWarning-message-enhancement
branch
from
d050d4e to
405b00f
Compare
mroeschke
approved these changes
Apr 18, 2024
|
Thanks @abeltavares |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Co-authored-by: Abel Tavares <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.