BUG: Let check_exact_index default to True for integers #58189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 22, 2024
mroeschke
added
the
Testing
|
No problem at all. Not sure how many tests are needed but I think this should be sufficient |
mroeschke
reviewed
Apr 23, 2024
pandas/_testing/asserters.py
Outdated
Comment on lines
930
to
931
| all(is_numeric_dtype(dtype) for dtype in left_index_dtypes) | ||
| and not any(is_float_dtype(dtype) for dtype in left_index_dtypes) |
There was a problem hiding this comment.
You could check dtype.kind in "iu" to check integer types in one go
There was a problem hiding this comment.
Brilliant! That doesn't seem to work for multiindexes (as in I can't just use this on index.dtype) as the dtype is always object (why?)
There was a problem hiding this comment.
That doesn't seem to work for multiindexes
Probably because MultiIndex can be composed of levels that are mixed types so object is the safest type
mroeschke
reviewed
Apr 23, 2024
mroeschke
reviewed
Apr 23, 2024
mroeschke
approved these changes
Apr 24, 2024
|
Thanks @Aloqeely |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…8189) * Default check_exact_index to True for integers * Fix pyright issue * fix logic for multiindex * Pre-commit stuff * Address review comments --------- Co-authored-by: Abdulaziz Aloqeely <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.