-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Add support for reading value labels from 108-format and prior Stata dta files #58155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
41d1f22
ENH: Add support for reading value labels from 108-format and prior S…
cmjcharlton 3feed75
Add type hints for value label dictionary
cmjcharlton be8aac5
Apply changes suggested by pylint
cmjcharlton dd14736
Clarify that only the 108 format has both 8 character (plus null term…
cmjcharlton c2836bf
Split function for reading value labels into newer and older format v…
cmjcharlton 3f2acb3
Merge remote-tracking branch 'upstream/main' into stata-old-valuelabels
cmjcharlton 2310022
Remove duplicate line
cmjcharlton bf8620c
Update type hints for value label dictionary keys to match read content
cmjcharlton 36acb33
Merge remote-tracking branch 'upstream/main' into stata-old-valuelabels
cmjcharlton af7d5e4
Indicate versions each value label helper function applies to via doc…
cmjcharlton b0dc320
Seek to value table location within version specific helper functions
cmjcharlton 792d10c
Wait until value labels are read before setting flag
cmjcharlton 445fbaf
Move value label dictionary initialisation to class __init__
cmjcharlton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps one last one. Should this be moved to the
__init__
? I prefer to declare all attributes there since it avoids late addition of attributes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now moved this up as suggested. I put it in the
# State variables for the file
section as this seemed the closest fit, but can shift it around it you like.