PERF: groupby returns a RangeIndex from groups when possible #58117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Apr 5, 2024
| @@ -754,7 +755,10 @@ def ids(self) -> npt.NDArray[np.intp]: | |||
|
|
|||
| @cache_readonly | |||
| def result_index_and_ids(self) -> tuple[Index, npt.NDArray[np.intp]]: | |||
| levels = [Index._with_infer(ping.uniques) for ping in self.groupings] | |||
| levels = [ | |||
| Index._with_infer(maybe_sequence_to_range(ping.uniques)) | |||
There was a problem hiding this comment.
Is this introducing values-dependent behavior? When grouping is [1, 2, 3] I'd get a RangeIndex but when it's [1, 2, 4] it's now an Index.
If they behave the same and so we can call this an implementation detail, then I'm good not calling this values-dependent behavior.
|
I think #58143 is a more generic application that affects this so closing in favor of that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #57441