DOC: read_sql_query docstring contraine wrong examples #58094 #58095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 1, 2024
pandas/io/sql.py
Outdated
| @@ -473,8 +473,9 @@ def read_sql_query( | |||
| -------- | |||
| >>> from sqlalchemy import create_engine # doctest: +SKIP | |||
| >>> engine = create_engine("sqlite:///database.db") # doctest: +SKIP | |||
| >>> sql_query = 'SELECT int_column FROM test_data # doctest: +SKIP | |||
There was a problem hiding this comment.
Suggested change
| >>> sql_query = 'SELECT int_column FROM test_data # doctest: +SKIP | |
| >>> sql_query = "SELECT int_column FROM test_data" # doctest: +SKIP |
There was a problem hiding this comment.
Thanks @mroeschke 👍 I do this to fast in the web IDE 😓
Tonow
force-pushed
the
read_sql_query_wrong_docsting
branch
from
04250bd to
c4574a2
Compare
mroeschke
approved these changes
Apr 2, 2024
|
Thanks @Tonow |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
(pandas-dev#58095) DOC: read_sql_query docstring contraine wrong examples pandas-dev#58094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.