-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: #57954 encoding ignored for filelike #57968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 11 commits into
pandas-dev:main
from
dontgoto:#57954_encoding_ignored_for_filelike
Mar 28, 2024
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cb49c21
add exception when encodings exist and do not match
dontgoto da616c4
add exception when encodings exist and do not match
dontgoto f35b3b3
add test for mismatching encodings warning
dontgoto 01f89f3
Merge remote-tracking branch 'origin/#57954_encoding_ignored_for_file…
dontgoto 6acc3f2
Merge remote-tracking branch 'upstream/main' into #57954_encoding_ign…
dontgoto 0a22297
add test for mismatching encodings warning
dontgoto efae8b8
add encoding for python 3.10+
dontgoto f13a23d
Merge branch 'main' into #57954_encoding_ignored_for_filelike
dontgoto 1e8cbfb
Merge branch 'main' into #57954_encoding_ignored_for_filelike
dontgoto 277a0d2
move to _check_file; invert var and condition
dontgoto 2402e20
Merge branch 'main' into #57954_encoding_ignored_for_filelike
dontgoto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check might be better in
_check_file_or_buffer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your suggestion, but trying that out the type checking throws errors. None of the annotated classes in
_make_engine
guarantee anencoding
attribute, so thegetattr
check would be necessary here anyway at least for the type checker.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK adding typing ignores as needed