DOC: #38067 add missing holiday observance rules #57939
Conversation
dontgoto
changed the title
|
Thanks @dontgoto
Yeah that makes sense to deprecate one of them if they are redundant |
Can I put in a deprecation notice for 4.0.0? Or something like that? |
|
My two cents here - I think "weekend_to_monday" is more accurate and descriptive, BUT if that's the one we keep it would make the most sense to also change the current "previous_friday" to "weekend_to_friday". I think it's clearest to keep the before/after and next/previous pairs as matched as possible ... so whichever gets deprecated, the pair should be either:
I prefer the former but wouldn't care too much if folks prefer the latter. |
I find the former function names make more sense , because in the end they only shift when on a weekend, the latter implies that weekdays are also shifted, but they're not. On the other hand, the latter ones have been in the user guide since forever, the former ones not. |
| @@ -1468,11 +1468,16 @@ or some other non-observed day. Defined observance rules are: | |||
| :header: "Rule", "Description" | |||
| :widths: 15, 70 | |||
|
|
|||
| "next_workday", "move Saturday and Sunday to Monday" | |||
| "previous_workday", "move Saturday and Sunday to Friday" | |||
There was a problem hiding this comment.
This one for 'previous workday' isn't quite right ... it moves to the previous workday even if the input is a weekday, not just for Sat and Sun (as opposed to what previous_friday does)
|
@dontgoto I agree on the "makes more sense" ... even though the others have been documented I think that can be got around by deprecating them for a while before they go away |
…v#57939) * fix method docstrings * add observances to user guide * add weekend_to_monday to user guide
Updated docs with missing functions.
weekend_to_mondayandnext_mondaydo indeed do the exact same thing, and I agree thatnext_mondayshould be deprecated. Any thoughts?