Skip to content

Fix tagging within Dockerfile #57935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Mar 20, 2024

When the user within a docker container does not match the user on the host machine (this is the case by default on Linux, not sure of all OSes) you cannot use git to inspect the worktree:

root@6de0debf3870:/home/pandas# git log
fatal: detected dubious ownership in repository at '/home/pandas'
To add an exception for this directory, call:

	git config --global --add safe.directory /home/pandas

This prevents builds within docker from being tagged with the appropriate git revision

Copy link
Member

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

Thanks!

@lithomas1 lithomas1 added this to the 3.0 milestone Mar 20, 2024
@mroeschke mroeschke merged commit d17723c into pandas-dev:main Mar 20, 2024
46 checks passed
@mroeschke
Copy link
Member

Thanks @WillAyd

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants