Skip to content

DOC: Update docs with the use of meson instead of setup.py #57917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

DeaMariaLeon
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Not sure if this is still needed: https://github.com/pandas-dev/pandas/blob/main/gitpod/gitpod.Dockerfile#L38C5-L38C45

@WillAyd
Copy link
Member

WillAyd commented Mar 19, 2024

I would go ahead and update the gitpod as well - no reason to still be using setuptools anywhere in our code base

@DeaMariaLeon
Copy link
Member Author

I think that the file gitpod.Dockerfile is not being used. Since it's not being called here: https://github.com/pandas-dev/pandas/blob/main/.gitpod.yml#L9C3-L9C19 (but of course, I could be wrong).

Plus it seems that there is some pending work for gitpod: #54046

Maybe updating gitpod could be done on a separate PR?

@WillAyd WillAyd merged commit a93fd6e into pandas-dev:main Mar 22, 2024
50 checks passed
@WillAyd
Copy link
Member

WillAyd commented Mar 22, 2024

Thanks @DeaMariaLeon

@DeaMariaLeon DeaMariaLeon deleted the meson branch March 22, 2024 15:11
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants