Skip to content

REF/PERF: Use concat(..., ignore_index=True) when index doesn't matter #57913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2024
Merged

REF/PERF: Use concat(..., ignore_index=True) when index doesn't matter #57913

merged 3 commits into from
Mar 22, 2024

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Mar 19, 2024 •
edited
Loading

For internal concat usages where the result index is set later, setting ignore_index=True to avoid More Work calculating the result concat index

@mroeschke mroeschke added Refactor Internal refactoring of code Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Mar 19, 2024
@mroeschke mroeschke requested a review from rhshadrach as a code owner March 19, 2024 17:38
@mroeschke mroeschke added this to the 3.0 milestone Mar 19, 2024
rhshadrach
rhshadrach approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit a789288 into pandas-dev:main Mar 22, 2024
46 checks passed
@rhshadrach
Copy link
Member

Thanks @mroeschke

@mroeschke mroeschke deleted the ref/concat/ignore_index branch March 22, 2024 20:52
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@mroeschke @pmhatre1
REF/PERF: Use concat(..., ignore_index=True) when index doesn't matter (
06f305d 
pandas-dev#57913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @rhshadrach