Skip to content

Revert "Fix issue with Tempita recompilation (#57796)" #57905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Mar 18, 2024

I don't think this had the intended effect - it did prevent unwanted recompilation but also ignored when the tempita files were updated and a recompilation should occur

@mroeschke mroeschke added this to the 2.2.2 milestone Mar 19, 2024
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn that's too bad. Thanks for circling back

@mroeschke mroeschke merged commit 594466a into pandas-dev:main Mar 19, 2024
46 of 47 checks passed
@mroeschke
Copy link
Member

Thanks @WillAyd

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 19, 2024
mroeschke pushed a commit that referenced this pull request Mar 19, 2024
…compilation (#57796)") (#57907)

Backport PR #57905: Revert "Fix issue with Tempita recompilation (#57796)"

Co-authored-by: William Ayd <[email protected]>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants