Skip to content

BUG: Handle Series construction with Dask, dict-like, Series #57889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 18, 2024
Merged

BUG: Handle Series construction with Dask, dict-like, Series #57889

merged 5 commits into from
Mar 18, 2024

Conversation

mroeschke
Copy link
Member

Should hopefully fix test_construct_dask_float_array_int_dtype_match_ndarray which is failing because dask Series now raises on __bool__?

@mroeschke mroeschke added Compat pandas objects compatability with Numpy or Python functions Series Series data structure Constructors Series/DataFrame/Index/pd.array Constructors labels Mar 18, 2024
phofl
phofl approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, fwiw bool(dask_series) was always raising, but we didn't get there since the legacy implementation didn't define keys, which made is_dict_like return false (I fixed this downstream as well, but this change makes sense either way)

@phofl phofl added this to the 2.2.2 milestone Mar 18, 2024
@phofl phofl merged commit 78e9f06 into pandas-dev:main Mar 18, 2024
46 of 47 checks passed
@phofl
Copy link
Member

phofl commented Mar 18, 2024

thx @mroeschke

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 18, 2024
@mroeschke @meeseeksmachine
Backport PR pandas-dev#57889: BUG: Handle Series construction with Da…
95e2e2d 
…sk, dict-like, Series
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 18, 2024
Merged
@phofl phofl mentioned this pull request Mar 18, 2024
Closed
@mroeschke mroeschke deleted the bug/series/dict branch March 18, 2024 20:59
lithomas1 pushed a commit that referenced this pull request Mar 18, 2024
@meeseeksmachine @mroeschke
Backport PR #57889 on branch 2.2.x (BUG: Handle Series construction w…
cc56321 
…ith Dask, dict-like, Series) (#57899)

Backport PR #57889: BUG: Handle Series construction with Dask, dict-like, Series

Co-authored-by: Matthew Roeschke <[email protected]>
aureliobarbosa added a commit to aureliobarbosa/pandas that referenced this pull request Mar 21, 2024
@aureliobarbosa
REF Series: incorporate changes from pandas-dev#57889
f3967ca
@aureliobarbosa aureliobarbosa mentioned this pull request Mar 21, 2024
Closed
4 tasks
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@mroeschke @pmhatre1
BUG: Handle Series construction with Dask, dict-like, Series (pandas-…
ca81c57 
…dev#57889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Constructors Series/DataFrame/Index/pd.array Constructors Series Series data structure
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @phofl