BUG: Replace on Series/DataFrame stops replacing after first NA #57865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringDtype
column with NA values stops replacing after first NA #56599doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.The issue was the line
a = a[mask]
was triggered only forndarray
and doesn't hit whendtype='string'
, but thenp.place
logic applied as long as the result was anndarray
.The old behavior had things like (depending on the number and location of NAs)