Skip to content

Fix 28021: Add 5% padding in timeseries line plot #57864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Compro-Prasad
Copy link
Contributor

@Compro-Prasad Compro-Prasad commented Mar 16, 2024

@Compro-Prasad
Copy link
Contributor Author

Compro-Prasad commented Mar 17, 2024

Was hunting through commits and found 3795272#diff-b742bb6314b1f7b55dd7a0987ae6102f529a8d4faa6a5524ba9122d47138ad23R393 which does the exact thing that I have done. But I don't know if this is the right way to do it because it was removed. I am new to this and would like some references to do this better.

@Compro-Prasad Compro-Prasad force-pushed the fix-ts-lineplot-padding branch from 364b8a1 to c16ff9a Compare March 17, 2024 07:20
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Apr 17, 2024
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. Additionally, I don't think adding arbitrary tolerances is a sufficient solution here. Closing but let's continue to discuss solutions in the original issue

@mroeschke mroeschke closed this Apr 17, 2024
@Compro-Prasad Compro-Prasad deleted the fix-ts-lineplot-padding branch August 15, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create correct xlim for ts plot and update datetimelike tests
2 participants