PERF: RangeIndex.insert maintains RangeIndex when empty #57833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Performance
|
cc @WillAyd if you have time could you help look at the ASAN / UBSAN builds? It looks like recently they have been failing with |
|
That is definitely strange. Do you know when that first started? My guess is the error is coming from something in our conftest or a third party dependency, since it looks like it happens before the test suite even begins |
|
This commit on main looks like it was the first one to exhibit the failure (but doesn't look like these changes should have caused it?) 10f31f6 |
|
Yea that looks unrelated. Guessing it's a dependency version issue |
phofl
approved these changes
Mar 16, 2024
|
thx @mroeschke |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #57441