PERF: RangeIndex.round returns RangeIndex when possible #57824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Performance
datapythonista
approved these changes
Mar 13, 2024
pandas/core/indexes/range.py
Outdated
| if decimals >= 0: | ||
| return self.copy() | ||
| elif all( | ||
| getattr(self, attr) % 10**-decimals == 0 for attr in ("start", "step") |
There was a problem hiding this comment.
Personal preference, but I'd find more readable to simply use self.start % 10 ... and self.stop % 10 ....
There was a problem hiding this comment.
Fair point. I'll change this to your suggestion
pandas/core/indexes/range.py
Outdated
| elif all( | ||
| getattr(self, attr) % 10**-decimals == 0 for attr in ("start", "step") | ||
| ): | ||
| # e.g. Range(10, 30, 10).round(-1) doesn't need rounding |
There was a problem hiding this comment.
Suggested change
| # e.g. Range(10, 30, 10).round(-1) doesn't need rounding | |
| # e.g. RangeIndex(10, 30, 10).round(-1) doesn't need rounding |
pandas/core/indexes/range.py
Outdated
| ---------- | ||
| decimals : int, optional | ||
| Number of decimal places to round to. If decimals is negative, | ||
| it specifies the number of positions to the left of the decimal point. |
There was a problem hiding this comment.
I know this is from the original docstring, but for me it's not obvious what this means by reading it, maybe adding an example or two here would be helpful.
There was a problem hiding this comment.
Sure thing. I added an example for the negative case.
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…7824) * PERF: RangeIndex.round returns RangeIndex when possible * Add whatsnew * Add typing * Address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.