Skip to content

CLN: Remove unused private code in sas module #57819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Mar 12, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@tqa236 tqa236 force-pushed the remove-private-variable-sas branch from 370e07d to 06fe6f7 Compare March 12, 2024 06:13
@datapythonista datapythonista added Clean IO SAS SAS: read_sas labels Mar 12, 2024
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the clean up @tqa236

@datapythonista datapythonista changed the title Remove unused private code in sas module CLN: Remove unused private code in sas module Mar 12, 2024
@mroeschke mroeschke added this to the 3.0 milestone Mar 12, 2024
@mroeschke mroeschke merged commit fb418b2 into pandas-dev:main Mar 12, 2024
@mroeschke
Copy link
Member

Thanks @tqa236

@tqa236 tqa236 deleted the remove-private-variable-sas branch March 12, 2024 17:46
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean IO SAS SAS: read_sas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants