Skip to content

CLN: Remove unused private attributes in stata module #57818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Mar 12, 2024

According to #49228, all of the internal state of the reader object is now _private, so I try to remove the unused one detected by vulture

@tqa236 tqa236 force-pushed the remove-private-variable branch from 9b16c59 to adb1115 Compare March 12, 2024 06:29
@datapythonista datapythonista changed the title Remove unused private attributes in stata module CLN: Remove unused private attributes in stata module Mar 12, 2024
@datapythonista datapythonista added IO Stata read_stata, to_stata Clean labels Mar 12, 2024
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the clean up @tqa236

@mroeschke mroeschke added this to the 3.0 milestone Mar 12, 2024
@mroeschke mroeschke merged commit f2a5272 into pandas-dev:main Mar 12, 2024
53 checks passed
@mroeschke
Copy link
Member

Thanks @tqa236

@tqa236 tqa236 deleted the remove-private-variable branch March 12, 2024 17:46
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean IO Stata read_stata, to_stata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants