Skip to content

Fix some typing errors #57816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 12, 2024
Merged

Fix some typing errors #57816

merged 12 commits into from
Mar 12, 2024

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Mar 11, 2024

No description provided.

@tqa236 tqa236 requested a review from rhshadrach as a code owner March 11, 2024 20:42
@tqa236
Copy link
Contributor Author

tqa236 commented Mar 11, 2024

pre-commit.ci autofix

@mroeschke mroeschke requested a review from twoertwein March 11, 2024 21:48
@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Mar 11, 2024
@tqa236 tqa236 requested a review from twoertwein March 12, 2024 06:33
@tqa236 tqa236 requested review from Dr-Irv and WillAyd as code owners March 12, 2024 13:34
twoertwein
twoertwein reviewed Mar 12, 2024
View reviewed changes
Dr-Irv
Dr-Irv requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we are still using the convention that when # type: ignore comments are added, we put in the mypy error report above that line in a comment.

Dr-Irv
Dr-Irv requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you not force push? It makes it hard to see what are your most recent changes

Dr-Irv
Dr-Irv approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, but will let @twoertwein do final review and merge. Need to decide TypeAlias issue.

@twoertwein twoertwein merged commit 10f31f6 into pandas-dev:main Mar 12, 2024
47 checks passed
@twoertwein
Copy link
Member

Thanks @tqa236 !

@tqa236 tqa236 deleted the typing2 branch March 12, 2024 23:43
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@tqa236 @pmhatre1
Fix some typing errors (pandas-dev#57816)
984cac3 
* Fix some typing errors

* Review

* Reuse types

* Reuse types

* Reuse types

* Add error message

* Add error message

* Revert "Reuse types"

This reverts commit 0e9e7bc.

* Revert "Reuse types"

This reverts commit 0fcb8cd.

* Revert "Reuse types"

This reverts commit 89dec50.

* Remove comment

* Add error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

@Dr-Irv Dr-Irv Dr-Irv approved these changes

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tqa236 @twoertwein @Dr-Irv @mroeschke