BUG: #57775 Fix groupby apply in case func returns None for all groups #57800
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
approved these changes
Mar 11, 2024
mroeschke
reviewed
Mar 11, 2024
pandas/core/groupby/groupby.py
Outdated
Comment on lines
1575
to
1581
| Groups for which ``func`` returns ``None`` will be filtered from the result. | ||
|
|
||
| .. versionchanged:: 2.2.2 | ||
|
|
||
| In case all groups are filtered from the result, an empty DataFrame | ||
| with the columns and dtypes of the original dataframe will be returned. | ||
|
|
There was a problem hiding this comment.
Suggested change
| Groups for which ``func`` returns ``None`` will be filtered from the result. | |
| .. versionchanged:: 2.2.2 | |
| In case all groups are filtered from the result, an empty DataFrame | |
| with the columns and dtypes of the original dataframe will be returned. |
(the example below is sufficient)
There was a problem hiding this comment.
Removed the description, only left the example
mroeschke
reviewed
Mar 11, 2024
doc/source/whatsnew/v2.2.2.rst
Outdated
| @@ -21,7 +21,7 @@ Fixed regressions | |||
|
|
|||
| Bug fixes | |||
| ~~~~~~~~~ | |||
| - | |||
| - :meth:`DataFrameGroupBy.apply` was returning a completely empty DataFrame when all return values of ``func`` were ``None`` instead of returning an empty DataFrame with the original columns and dtypes. (:issue:`57775`) | |||
There was a problem hiding this comment.
Can you move this to v3.0.0.rst?
mroeschke
reviewed
Mar 11, 2024
doc/source/whatsnew/v2.2.2.rst
Outdated
| @@ -22,7 +22,6 @@ Fixed regressions | |||
| Bug fixes | |||
| ~~~~~~~~~ | |||
| - | |||
|
|
|||
There was a problem hiding this comment.
Could you undo this white space change?
There was a problem hiding this comment.
Done. Thanks, I missed that one.
mroeschke
approved these changes
Mar 12, 2024
|
Thanks @dontgoto |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
… all groups (pandas-dev#57800) * Ensure that the empty frame has the information of the original frame * Adjust test to expect DataFrame with columns * Construct leaner dataframe * Update doc * Add example to doc * Update whatsnew * Add issue #; phrasing * Fix doc * Fix doc * Fix docstring formatting * move from 2.2.2 to 3.0.0 * remove description * fix whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.2.2.rstfile if fixing a bug or adding a new feature.In case the func passed to DataFrameGroupBy.apply returns None for all groups (filtering out all groups), the original dataframe's columns and dtypes are now part of the empty result dataframe.