Skip to content

API: Revert 57042 - MultiIndex.names|codes|levels returns tuples #57788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2024

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Manual revert of #57042

Closes #57607

The behavior described in that issue seems quite undesirable, especially for a breaking change.

cc @mroeschke

@mroeschke
Copy link
Member

I would be OK reverting this but would like:

  1. To expose FrozenList in pandas.api.typing
  2. Deprecate the union and difference methods

@rhshadrach
Copy link
Member Author

I would be OK reverting this but would like:

  1. To expose FrozenList in pandas.api.typing
  2. Deprecate the union and difference methods

Okay with doing this in a follow up? (I likely won't be able to return to this for ~1 week in any case)

@mroeschke
Copy link
Member

Okay with doing this in a follow up? (I likely won't be able to return to this for ~1 week in any case)

Yup that's good

@phofl
Copy link
Member

phofl commented Mar 18, 2024

Deprecate the union and difference methods

what's the reasoning for those deprecations?

@mroeschke
Copy link
Member

what's the reasoning for those deprecations?

Mainly cleanup. IMO if we keep FrozenList and make it available as a public API, that API should be minimal

@rhshadrach rhshadrach marked this pull request as ready for review March 20, 2024 21:30
@rhshadrach rhshadrach requested a review from WillAyd as a code owner March 20, 2024 21:30
@rhshadrach rhshadrach added this to the 3.0 milestone Mar 20, 2024
@rhshadrach rhshadrach requested a review from mroeschke April 10, 2024 02:45
@mroeschke mroeschke merged commit 2e9e89a into pandas-dev:main Apr 11, 2024
46 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the revert_index_frozen branch April 11, 2024 21:31
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…das-dev#57788)

* API: Revert 57042 - MultiIndex.names|codes|levels returns tuples

* Typing fixup

* Docstring fixup

* ruff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Possible bad api side effect of replacing FrozenList with tuple
3 participants