PERF: Allow ensure_index_from_sequence to return RangeIndex #57786
Conversation
mroeschke
added
Performance
pandas/core/indexes/base.py
Outdated
| ------- | ||
| Any : input or range | ||
| """ | ||
| if hasattr(sequence, "dtype") and not isinstance(sequence, np.ndarray): |
There was a problem hiding this comment.
I find the duck typing here somewhat non-obvious - maybe comments will help? Is this first branch supposed to be for extension types?
There was a problem hiding this comment.
Is this first branch supposed to be for extension types?
Essentially yes, I think I can use a more specific check here
There was a problem hiding this comment.
Updated the check here to be more explicit (exclude Series and Index objects)
| return sequence | ||
| elif len(sequence) == 0: | ||
| return range(0) | ||
| diff = np_sequence[1] - np_sequence[0] |
There was a problem hiding this comment.
Why are only the first two elements important here?
There was a problem hiding this comment.
We're taking an example diff here (just between the first 2 elements) and later seeing if the rest of the diffs between the rest of the elements match
|
Any other comments here @WillAyd? |
|
Nope all good. And thanks for the ping - sorry sometimes fall behind on notifications |
Discovered in #57441
Builds on #57752