Skip to content

Fix SparseDtype comparison #57783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Fix SparseDtype comparison #57783

merged 4 commits into from
Mar 9, 2024

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Mar 8, 2024

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you add a whatsnew note to v3.0.0.rst?

@mroeschke mroeschke added the Sparse Sparse Data Type label Mar 8, 2024
@tqa236
Copy link
Contributor Author

tqa236 commented Mar 9, 2024

Thank you for your review. I added a whatsnew note.

@mroeschke mroeschke added this to the 3.0 milestone Mar 9, 2024
@mroeschke mroeschke merged commit 77f9d7a into pandas-dev:main Mar 9, 2024
@mroeschke
Copy link
Member

Thanks @tqa236

@tqa236 tqa236 deleted the na-sparsedtype branch March 9, 2024 21:13
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* Fix SparseDtype comparison

* Fix tests

* Add whatsnew

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sparse Sparse Data Type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: pd.SparseDtype('int', 0) == pd.SparseDtype('int', pd.NA) returns pd.NA
2 participants