CLN: Hashtable rename struct members #57704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
changed the title
|
Seems like there is a conflict now, if you want to have a look... |
|
One more conflict here otherwise LGTM |
mroeschke
reviewed
Mar 20, 2024
| @@ -164,7 +164,7 @@ ctypedef fused vector_data: | |||
| StringVectorData | |||
|
|
|||
| cdef bint needs_resize(vector_data *data) noexcept nogil: | |||
| return data.n == data.m | |||
| return data.size == data.capacity | |||
There was a problem hiding this comment.
I don't know if size ever increments more than 1 before checking, but a >= would probably be safer here.
mroeschke
approved these changes
Mar 20, 2024
|
Thanks @WillAyd |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Hashtable rename struct members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with readability