Less Heap Usage in Hashtable #57701
Merged
Less Heap Usage in Hashtable #57701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Mar 2, 2024
| @@ -644,15 +628,13 @@ cdef class {{name}}HashTable(HashTable): | |||
| int ret = 0 | |||
| {{c_type}} val, na_value2 | |||
| khiter_t k | |||
| {{name}}VectorData *ud | |||
There was a problem hiding this comment.
Something very strange was going on here, where changing this to a non-pointer and assigning ud = uniques.data then trying to pass that via reference to needs_resize was failing. I think has something to do with Cython pointer/reference semantics, but rather than dive too deep figured it was trivial enough to just remove
mroeschke
approved these changes
Mar 5, 2024
|
Thanks @WillAyd |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Hashtable cleanups * Remove unused imports * renamed .n -> size, .m -> capacity * size_t -> Py_ssize_t * revert needs_resize * remove unnecessary pointers * fix build issues * Removed ud variable * Fix ObjectVector issue * try setting NULL in dealloc * reset things * try smaller scope * Smaller scope * less change * remove unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.