DOC: Add clarification to groupby docs regarding hashes and equality #57648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Feb 28, 2024
pandas/core/shared_docs.py
Outdated
| @@ -174,6 +174,12 @@ | |||
|
|
|||
| Notes | |||
| ----- | |||
| The implementation of groupby is hash-based, meaning in particular that | |||
There was a problem hiding this comment.
Can you move this below the other note? I think the link to the user guide should be the most prominent. It's not a big deal right now, but would be if this section gets expanded more on in the future.
There was a problem hiding this comment.
Thanks for the review! Will do.
|
@gabuzi do you have time to address the comments from the review? |
Yes, thanks for the ping. |
|
Thanks @gabuzi! |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #57526