Skip to content

DOC: RT03 fix for read_sql method #57638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

YashpalAhlawat
Copy link
Contributor

@YashpalAhlawat YashpalAhlawat commented Feb 27, 2024

@YashpalAhlawat YashpalAhlawat changed the title RT03 fix for read_sql method DCO: RT03 fix for read_sql method Feb 27, 2024
@YashpalAhlawat YashpalAhlawat changed the title DCO: RT03 fix for read_sql method DOC: RT03 fix for read_sql method Feb 27, 2024
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @YashpalAhlawat, I added a couple of comments.

@datapythonista datapythonista added Docs IO SQL to_sql, read_sql, read_sql_query labels Feb 27, 2024
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @YashpalAhlawat

@mroeschke mroeschke added this to the 3.0 milestone Feb 27, 2024
@mroeschke mroeschke merged commit 737d390 into pandas-dev:main Feb 27, 2024
@mroeschke
Copy link
Member

Thanks @YashpalAhlawat

@YashpalAhlawat YashpalAhlawat deleted the RT03_issue_for_read_sql branch February 27, 2024 17:03
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* RT03 fix for read_sql method

* Review suggestions implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants