Compile take functions for uint dtypes #57632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine. Are these actually called? |
mroeschke
added
the
Internals
|
Those are more or less user facing, we end up calling them if users have uint dtypes (that's how we found this in Dask) good to merge @WillAyd? |
|
Yep merge away |
|
thx |
|
For all dtypes of the same itemsize, is it possible to e.g. view them as an int8/16/32/64, and just have one kernel that does int->int take, or is this undefined behavior? |
|
Would still require a copy and this is a path that is very heavily used. |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this wasn't compiled before, maybe because of wheel size? We should at least compile the exact matching, not averse to skipping the cross product with different itemsizes