TYP: misc annotations #57606
Merged
TYP: misc annotations #57606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Feb 25, 2024
| IndexLabel, | ||
| ReadCsvBuffer, | ||
| Self, | ||
| StorageOptions, | ||
| Unpack, | ||
| UsecolsArgType, | ||
| ) | ||
|
|
||
| class _read_shared(TypedDict, Generic[HashableT], total=False): |
There was a problem hiding this comment.
Moved in TYPE_CHECKING block - older python versions do not allow a TypedDict to inherit form non-TypedDict base classes (Generic)
twoertwein
requested review from
rhshadrach,
Dr-Irv and
MarcoGorelli
as code owners
mroeschke
approved these changes
Feb 26, 2024
|
Thanks @twoertwein |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* TYP: misc changes * fix runtime * pre-commit * a few more * stubtest * NoReturn for <3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to pass more of the pandas-stubs tests.