ENH: closing issues #395, #449, #570, #571 #576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -491,34 +491,11 @@ def set_eng_float_format(precision=3, use_eng_prefix=False): | |||
| _float_format = EngFormatter(precision, use_eng_prefix) | |||
| _column_space = max(12, precision + 9) | |||
|
|
|||
| _float_format = lambda x: '%.4g' % x | |||
| _float_format = lambda x: '% .4f' % x | |||
There was a problem hiding this comment.
This will lead to very small numbers showing up as 0.0000 I think
|
This is great. You have some trailing whitespace problems-- is your editor configured to strip trailing whitespace? I think we can set git to do it automatically on commit. The new string formatting looks awesome. There's a tiny buglet with padding zeros on scientific notation: Can fix it separately after merging this-- the rebase was somewhat terrifying but appears to have gone through cleanly |
|
OK I think I got that buglet licked here: and off to bed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix column string formatting; index and header options to to_string; decorator for docstrings; floating point prettier printing. Also added to release notes & documentation. Address #395, #449, #570, #571