Skip to content

TYP: fix mypy failures on main in pandas/core/generic.py #57522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

natmokval
Copy link
Contributor

@natmokval natmokval commented Feb 20, 2024

fixed mypy failure on main in pandas/core/generic.py:

pandas/core/generic.py:6463: error: Argument "deep" to "copy" of "BaseBlockManager" has incompatible type "bool | None"; expected "bool | Literal['all']"  [arg-type]

@natmokval natmokval added the Typing type annotations, mypy/pyright type checking label Feb 20, 2024
@natmokval natmokval marked this pull request as ready for review February 20, 2024 11:46
@mroeschke mroeschke added this to the 3.0 milestone Feb 20, 2024
@mroeschke mroeschke merged commit 260a703 into pandas-dev:main Feb 20, 2024
@mroeschke
Copy link
Member

Thanks @natmokval

@mroeschke
Copy link
Member

cc @phofl for the copy typing issue

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…57522)

* fix mypy failures in pandas/core/generic.py

* move back my changes in line 7454, 7471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants