REGR: DataFrame.update emits spurious warning about downcasting #57485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Dtype Conversions
|
thx @rhshadrach Can you put up a pr with a whatsnew that adds this to main? Only the whatsnew change |
rhshadrach
added a commit
to rhshadrach/pandas
that referenced
this pull request
Feb 19, 2024
5 tasks
phofl
pushed a commit
that referenced
this pull request
Feb 19, 2024
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This is meant as a stopgap - I plan to finish up #55634 for 3.0 which will avoid any upcasting/downcasting altogether. However I do no like the idea of that PR being put in a patch version since it is an entirely new approach to
DataFrame.update.I think this can't go in main because the warning and downcasting behavior has already been removed there.